From 33935e78aa3a44f3f1ddc1c0227c7a1fc27cc014 Mon Sep 17 00:00:00 2001 From: Mustafain Ali Khan Date: Sat, 25 Sep 2021 08:54:45 -0400 Subject: [PATCH] fix: remove usage of serviceName property in tests for otel collector (#2491) --- .../test/node/CollectorMetricExporter.test.ts | 1 - .../test/node/CollectorTraceExporter.test.ts | 1 - 2 files changed, 2 deletions(-) diff --git a/packages/opentelemetry-exporter-otlp-http/test/node/CollectorMetricExporter.test.ts b/packages/opentelemetry-exporter-otlp-http/test/node/CollectorMetricExporter.test.ts index 2fd9e04a36..4937ef3737 100644 --- a/packages/opentelemetry-exporter-otlp-http/test/node/CollectorMetricExporter.test.ts +++ b/packages/opentelemetry-exporter-otlp-http/test/node/CollectorMetricExporter.test.ts @@ -72,7 +72,6 @@ describe('OTLPMetricExporter - node with json over http', () => { // Need to stub/spy on the underlying logger as the "diag" instance is global const spyLoggerWarn = sinon.stub(diag, 'warn'); collectorExporter = new OTLPMetricExporter({ - serviceName: 'basic-service', url: address, metadata, } as any); diff --git a/packages/opentelemetry-exporter-otlp-http/test/node/CollectorTraceExporter.test.ts b/packages/opentelemetry-exporter-otlp-http/test/node/CollectorTraceExporter.test.ts index 7ccf6a97f1..8988572b67 100644 --- a/packages/opentelemetry-exporter-otlp-http/test/node/CollectorTraceExporter.test.ts +++ b/packages/opentelemetry-exporter-otlp-http/test/node/CollectorTraceExporter.test.ts @@ -58,7 +58,6 @@ describe('OTLPTraceExporter - node with json over http', () => { // Need to stub/spy on the underlying logger as the "diag" instance is global const spyLoggerWarn = sinon.stub(diag, 'warn'); collectorExporter = new OTLPTraceExporter({ - serviceName: 'basic-service', metadata, url: address, } as any);