test: startActiveSpan ensure that ctx sent is used

also add commented out span equality assertions to be uncommented before
merging

Signed-off-by: naseemkullah <[email protected]>

Author: naseemkullah

packages/opentelemetry-tracing/test/Tracer.test.ts

@@ -16,6 +16,8 @@
 
 import {
   context,
+  createContextKey,
+  getSpan,
   INVALID_TRACEID,
   ROOT_CONTEXT,
   Sampler,
@@ -222,7 +224,7 @@ describe('Tracer', () => {
     span.end();
   });
 
-  it('should start an active span with name and function as args', () => {
+  it('should start an active span with name and function args', () => {
     const tracer = new Tracer(
       { name: 'default', version: '0.0.1' },
       { sampler: new TestSampler() },
@@ -231,14 +233,15 @@ describe('Tracer', () => {
 
     assert.strictEqual(tracer.startActiveSpan('my-span', span => {
       try {
+        // assert.strictEqual(getSpan(context.active()), span)
         return 1
       } finally {
         span.end();
       }
     }), 1);
   });
 
-  it('should start an active span with name, options and functin as args', () => {
+  it('should start an active span with name, options and function args', () => {
     const tracer = new Tracer(
       { name: 'default', version: '0.0.1' },
       { sampler: new TestSampler() },
@@ -247,22 +250,29 @@ describe('Tracer', () => {
 
     assert.strictEqual(tracer.startActiveSpan('my-span', {}, span => {
       try {
+        // assert.strictEqual(getSpan(context.active()), span)
         return 1
       } finally {
         span.end();
       }
     }), 1);
   });
 
-  it('should start an active span with name, options, context and function as args', () => {
+  it('should start an active span with name, options, context and function args', () => {
     const tracer = new Tracer(
       { name: 'default', version: '0.0.1' },
       { sampler: new TestSampler() },
       tracerProvider
     );
 
-    assert.strictEqual(tracer.startActiveSpan('my-span', {}, context.active(), span => {
+    const ctxKey = createContextKey('foo');
+
+    const ctx = context.active().setValue(ctxKey, 'bar')
+
+    assert.strictEqual(tracer.startActiveSpan('my-span', {}, ctx, span => {
       try {
+        // assert.strictEqual(getSpan(context.active()), span)
+        assert.strictEqual(ctx.getValue(ctxKey), 'bar')
         return 1
       } finally {
         span.end();