Skip to content

Commit 1c6e8b2

Browse files
fix(instrumentation)!: remove unused supportedVersions from Instrumentation interface (#4694)
* chore: CHANGLOG * fix(instrumentation): remove unused property from instrumentations * chore: CHANGELOG --------- Co-authored-by: Marc Pichler <[email protected]>
1 parent 15b3526 commit 1c6e8b2

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

experimental/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ All notable changes to experimental packages in this project will be documented
1717
* (internal) OTLPExporterBrowserBase: `RequestType` has been replaced by a `ResponseType` type-argument
1818
* (internal) OTLPExporterNodeBase: `ServiceRequest` has been replaced by a `ServiceResponse` type-argument
1919
* (internal) the `@opentelemetry/otlp-exporter-proto-base` package has been removed, and will from now on be deprecated in `npm`
20+
* fix(instrumentation)!: remove unused supportedVersions from Instrumentation interface [#4694](https://github.com/open-telemetry/opentelemetry-js/pull/4694) @blumamir
2021

2122
### :rocket: (Enhancement)
2223

experimental/packages/opentelemetry-instrumentation/src/types.ts

-10
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,6 @@ export interface Instrumentation<
5454

5555
/** Method to get instrumentation config */
5656
getConfig(): ConfigType;
57-
58-
/**
59-
* Contains all supported versions.
60-
* All versions must be compatible with [semver](https://semver.org/spec/v2.0.0.html) format.
61-
* If the version is not supported, we won't apply instrumentation patch (see `enable` method).
62-
* If omitted, all versions of the module will be patched.
63-
*/
64-
supportedVersions?: string[];
6557
}
6658

6759
/**
@@ -102,8 +94,6 @@ export interface InstrumentationModuleFile {
10294
/** Method to patch the instrumentation */
10395
patch(moduleExports: unknown, moduleVersion?: string): unknown;
10496

105-
/** Method to patch the instrumentation */
106-
10797
/** Method to unpatch the instrumentation */
10898
unpatch(moduleExports?: unknown, moduleVersion?: string): void;
10999
}

0 commit comments

Comments
 (0)