chore: no-floating-promises (#1780)

Co-authored-by: Daniel Dyla <[email protected]>

eslint.config.js

@@ -4,27 +4,28 @@ module.exports = {
     "header"
   ],
   extends: [
-      "./node_modules/gts",
+    "./node_modules/gts",
   ],
   parser: "@typescript-eslint/parser",
   parserOptions: {
-      "project": "./tsconfig.json"
+    "project": "./tsconfig.json"
   },
   rules: {
+    "@typescript-eslint/no-floating-promises": 2,
     "@typescript-eslint/no-this-alias": "off",
     "eqeqeq": [
       "error",
       "smart"
     ],
     "prefer-rest-params": "off",
     "@typescript-eslint/naming-convention": [
-        "error",
-        {
-          "selector": "memberLike",
-          "modifiers": ["private", "protected"],
-          "format": ["camelCase"],
-          "leadingUnderscore": "require"
-        }
+      "error",
+      {
+        "selector": "memberLike",
+        "modifiers": ["private", "protected"],
+        "format": ["camelCase"],
+        "leadingUnderscore": "require"
+      }
     ],
     "no-console": "error",
     "no-shadow": "off",
@@ -35,8 +36,8 @@ module.exports = {
     "prettier/prettier": ["error", { "singleQuote": true, "arrowParens": "avoid" }],
     "node/no-deprecated-api": ["warn"],
     "header/header": [2, "block", [{
-        pattern: / \* Copyright The OpenTelemetry Authors[\r\n]+ \*[\r\n]+ \* Licensed under the Apache License, Version 2\.0 \(the \"License\"\);[\r\n]+ \* you may not use this file except in compliance with the License\.[\r\n]+ \* You may obtain a copy of the License at[\r\n]+ \*[\r\n]+ \*      https:\/\/www\.apache\.org\/licenses\/LICENSE-2\.0[\r\n]+ \*[\r\n]+ \* Unless required by applicable law or agreed to in writing, software[\r\n]+ \* distributed under the License is distributed on an \"AS IS\" BASIS,[\r\n]+ \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.[\r\n]+ \* See the License for the specific language governing permissions and[\r\n]+ \* limitations under the License\./gm,
-        template:
+      pattern: / \* Copyright The OpenTelemetry Authors[\r\n]+ \*[\r\n]+ \* Licensed under the Apache License, Version 2\.0 \(the \"License\"\);[\r\n]+ \* you may not use this file except in compliance with the License\.[\r\n]+ \* You may obtain a copy of the License at[\r\n]+ \*[\r\n]+ \*      https:\/\/www\.apache\.org\/licenses\/LICENSE-2\.0[\r\n]+ \*[\r\n]+ \* Unless required by applicable law or agreed to in writing, software[\r\n]+ \* distributed under the License is distributed on an \"AS IS\" BASIS,[\r\n]+ \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.[\r\n]+ \* See the License for the specific language governing permissions and[\r\n]+ \* limitations under the License\./gm,
+      template:
         `\n * Copyright The OpenTelemetry Authors\n *\n * Licensed under the Apache License, Version 2.0 (the "License");\n * you may not use this file except in compliance with the License.\n * You may obtain a copy of the License at\n *\n *      https://www.apache.org/licenses/LICENSE-2.0\n *\n * Unless required by applicable law or agreed to in writing, software\n * distributed under the License is distributed on an "AS IS" BASIS,\n * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n * See the License for the specific language governing permissions and\n * limitations under the License.\n `
     }]]
   },
@@ -48,6 +49,7 @@ module.exports = {
         "@typescript-eslint/ban-ts-ignore": "off",
         "@typescript-eslint/no-empty-function": "off",
         "@typescript-eslint/no-explicit-any": "off",
+        "@typescript-eslint/no-floating-promises": 1,
         "@typescript-eslint/no-unused-vars": "off",
         "@typescript-eslint/no-var-requires": "off",
         "@typescript-eslint/no-shadow": ["off"],

packages/opentelemetry-exporter-collector-grpc/src/util.ts

@@ -14,18 +14,18 @@
  * limitations under the License.
  */
 
-import { diag } from '@opentelemetry/api';
+import * as grpc from '@grpc/grpc-js';
 import * as protoLoader from '@grpc/proto-loader';
+import { diag } from '@opentelemetry/api';
+import { globalErrorHandler } from '@opentelemetry/core';
 import { collectorTypes } from '@opentelemetry/exporter-collector';
-import * as grpc from '@grpc/grpc-js';
 import * as path from 'path';
-
+import { CollectorExporterNodeBase } from './CollectorExporterNodeBase';
 import {
   CollectorExporterConfigNode,
   GRPCQueueItem,
   ServiceClientType,
 } from './types';
-import { CollectorExporterNodeBase } from './CollectorExporterNodeBase';
 
 export function onInit<ExportItem, ServiceRequest>(
   collector: CollectorExporterNodeBase<ExportItem, ServiceRequest>,
@@ -68,6 +68,9 @@ export function onInit<ExportItem, ServiceRequest>(
           collector.send(item.objects, item.onSuccess, item.onError);
         });
       }
+    })
+    .catch(err => {
+      globalErrorHandler(err);
     });
 }
 

packages/opentelemetry-metrics/src/export/Controller.ts

@@ -37,7 +37,9 @@ export class PushController extends Controller {
   ) {
     super();
     this._timer = setInterval(() => {
-      this._collect();
+      this._collect().catch(err => {
+        globalErrorHandler(err);
+      });
     }, interval);
     unrefTimer(this._timer);
   }

packages/opentelemetry-tracing/src/export/BatchSpanProcessor.ts

@@ -170,14 +170,14 @@ export class BatchSpanProcessor implements SpanProcessor {
     if (this._timer !== undefined) return;
     this._timer = setTimeout(() => {
       this._flushOneBatch()
-        .catch(e => {
-          globalErrorHandler(e);
-        })
         .then(() => {
           if (this._finishedSpans.length > 0) {
             this._clearTimer();
             this._maybeStartTimer();
           }
+        })
+        .catch(e => {
+          globalErrorHandler(e);
         });
     }, this._scheduledDelayMillis);
     unrefTimer(this._timer);