-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use Otel SDK 1.2/0.28 #984
Conversation
Codecov Report
@@ Coverage Diff @@
## main #984 +/- ##
==========================================
- Coverage 95.91% 92.23% -3.68%
==========================================
Files 13 129 +116
Lines 856 5926 +5070
Branches 178 1144 +966
==========================================
+ Hits 821 5466 +4645
- Misses 35 460 +425
|
I tried to keep the changes low here. I have not adapted the host-metrics package as I'm not that familiar with metrics API. There are still some dependencies to SDK packages like
|
I prefer this as it will allow users to update the SDK (patch / minor) without updating each instrumentation they use.
I think that if an instrumentation does not use any feature from a new minor version, it is cleaner to allow it to use old SDK so it's less hassel for users to update SDK version. |
In general I'm fine with allowing older SDKs. Main issue is that there is no test actually verifying that it works as we install newest in our tests so it's easy to miss. |
We can use test all versions but the CI will take a very long time. We should do it at least for releases though |
I've updated the host-metrics at #990. |
Is it ok to merge this or do we require approval of owners of all effected packages? |
I think if @dyladan is fine with it we can merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awesome, thanks!
Which problem is this PR solving?
fixes #983
Short description of the changes
use ^0.28.0 in dependencies to SDK experimental packages
use 1.2.0 in dev-dependencies
Checklist
npm run test-all-versions
for the edited package(s) on the latest commit if applicable.