Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate examples for koa instrumentation #950

Closed
andyfleming opened this issue Mar 16, 2022 · 4 comments
Closed

Migrate examples for koa instrumentation #950

andyfleming opened this issue Mar 16, 2022 · 4 comments
Assignees
@haddasbronfman
Labels
good first issue instrumentation-request up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@andyfleming
Copy link
Contributor

We're moving instrumentation examples from the top-level examples folder to the individual instrumentation packages to help keep them up to date. See the original PR here.

This issue is specifically for the @opentelemetry/instrumentation-koa examples.

Step-by-step instructions for migrating these examples can be found in examples/README.md.
@andyfleming andyfleming mentioned this issue Mar 16, 2022
Merged
1 task
@andyfleming
Copy link
Contributor Author

@dyladan @Flarna @rauno56 — Here's an example issue for migrating a given instrumentation package. Let me know if you think anything else needs included in the issue description. Also would be great to tag these with "Good First Issue". Thanks!

@rauno56 rauno56 added up-for-grabs Good for taking. Extra help will be provided by maintainers good first issue labels May 3, 2022
@rauno56
Copy link
Member

rauno56 commented May 3, 2022

I think this is perfect! The example PR can be really good guidance for what is expected!

@haddasbronfman
Copy link
Member

Hi, can you assign it to me please?

@haddasbronfman haddasbronfman mentioned this issue Aug 15, 2022
Merged
@andyfleming
Copy link
Contributor Author

Resolved by #1118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haddasbronfman haddasbronfman

Labels
good first issue instrumentation-request up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andyfleming @rauno56 @haddasbronfman