-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename lerna's --include-filtered-dependencies option #817
Merged
rauno56
merged 3 commits into
open-telemetry:main
from
rauno56:fix/rename-include-filtered-deps
Jan 4, 2022
Merged
fix: rename lerna's --include-filtered-dependencies option #817
rauno56
merged 3 commits into
open-telemetry:main
from
rauno56:fix/rename-include-filtered-deps
Jan 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned blumamir, legendecas, naseemkullah, NathanielRN, obecny, rauno56 and willarmiros
Jan 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #817 +/- ##
==========================================
+ Coverage 94.91% 95.08% +0.17%
==========================================
Files 14 200 +186
Lines 708 13764 +13056
Branches 142 1312 +1170
==========================================
+ Hits 672 13088 +12416
- Misses 36 676 +640
|
vmarchaud
approved these changes
Jan 4, 2022
vmarchaud
reviewed
Jan 4, 2022
naseemkullah
approved these changes
Jan 4, 2022
legendecas
approved these changes
Jan 4, 2022
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
--include-filtered-dependencies
option is deprecated:lerna/lerna@f2c3a92
Short description of the changes
Rename
--include-filtered-dependencies
->--include-dependencies
.Also substituting
$(npm pkg get name)
in thepackage.json
of@opentelemetry/instrumentation-aws-sdk
- GHA logs seem to tell us it's not properly working.