-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
instrumentation-document-load doesn't support re-enables #616
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This issue was closed because it has been stale for 14 days with no activity. |
What version of OpenTelemetry are you using?
What version of Node are you using?
12.7.0
What did you do?
I enabled
DocumentLoadInstrumentation
twice.What did you expect to see?
Only one trace with
documentLoad
span to be created.What did you see instead?
Two traces were generated.
Additional context
Instrumentations can be disabled and re-enabled in runtime. Other JS instrumentations like XHR or fetch supports re-enabling.
In my opinion the
instrumentation-document-load
should does nothing after being enabled again.The text was updated successfully, but these errors were encountered: