Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrumentation-document-load doesn't support re-enables #616

Closed
kkruk-sumo opened this issue Aug 12, 2021 · 4 comments
Closed

instrumentation-document-load doesn't support re-enables #616

kkruk-sumo opened this issue Aug 12, 2021 · 4 comments
Labels
bug Something isn't working stale

Comments

@kkruk-sumo
Copy link
Contributor

kkruk-sumo commented Aug 12, 2021

What version of OpenTelemetry are you using?

"@opentelemetry/api": "^1.0.2",
"@opentelemetry/instrumentation": "^0.24.0",
"@opentelemetry/instrumentation-document-load": "^0.24.0",
"@opentelemetry/web": "^0.24.0",

What version of Node are you using?

12.7.0

What did you do?

I enabled DocumentLoadInstrumentation twice.

What did you expect to see?

Only one trace with documentLoad span to be created.

What did you see instead?

Two traces were generated.

Additional context

Instrumentations can be disabled and re-enabled in runtime. Other JS instrumentations like XHR or fetch supports re-enabling.
In my opinion the instrumentation-document-load should does nothing after being enabled again.

@kkruk-sumo kkruk-sumo added the bug Something isn't working label Aug 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2021

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Nov 1, 2021
@dyladan dyladan removed the stale label Nov 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jan 3, 2022
@dyladan dyladan removed the stale label Jan 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Mar 7, 2022
@github-actions
Copy link
Contributor

This issue was closed because it has been stale for 14 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants