Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis attributes not aligned with latest semantic conventions #2450

Open
luke6Lh43 opened this issue Sep 24, 2024 · 1 comment
Open

Redis attributes not aligned with latest semantic conventions #2450

luke6Lh43 opened this issue Sep 24, 2024 · 1 comment

Comments

@luke6Lh43
Copy link

luke6Lh43 commented Sep 24, 2024

What version of OpenTelemetry are you using?

"@opentelemetry/api": "^1.9.0"
"@opentelemetry/auto-instrumentations-node": "^0.50.0"
"@opentelemetry/exporter-trace-otlp-http": "^0.53.0"
"@opentelemetry/sdk-node": "^0.53.0"

What version of Node are you using?

Node.js 22.9.0, NPM 10.8.3

What did you do?

https://github.com/luke6Lh43/otel-redis-testing/blob/main/Readme.md#nodejs

Additional context

Hello,

I have recently been working on a project that required Redis instrumentation for two different languages. During this process, I noticed some discrepancies in the attributes being collected. To investigate further, I conducted testing to check the attributes collected for Redis instrumentation across six of the most popular languages. I have documented my testing in this GitHub repository:

[Link to GitHub Repo]

Findings for Node.js:

What We Capture Today ==> How It Should Look in Latest Semantic Conventions

db.system: redis ==> db.system: redis
net.peer.name: localhost ==> network.peer.name: localhost
net.peer.port: 6379 ==> network.peer.port: 6379
db.connection_string: redis://localhost:6379 ==> (Not needed)
(Not captured) ==> db.query.text: GET myKey
(Not captured) ==> db.namespace: 0

@luke6Lh43 luke6Lh43 added the bug Something isn't working label Sep 24, 2024
@dyladan dyladan added priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect feature-request and removed bug Something isn't working priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect labels Sep 25, 2024
@dyladan
Copy link
Member

dyladan commented Sep 25, 2024

Changing to a feature request because this isn't wrong it's just old.

According to https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/database-spans.md we shouldn't update database instrumentations until they're stabilized in semconv, so this is on hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants