Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Express v5 #2435

Open
timfish opened this issue Sep 17, 2024 · 3 comments · May be fixed by #2437
Open

Add support for Express v5 #2435

timfish opened this issue Sep 17, 2024 · 3 comments · May be fixed by #2437
Assignees
@timfish
Labels
feature-request pkg:instrumentation-express

Comments

@timfish
Copy link
Contributor

timfish commented Sep 17, 2024

Express v5 has been released and it's not supported:

opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-express/src/instrumentation.ts

Lines 61 to 62 in 80c2f1a

'express',
['>=4.0.0 <5'],

I'm looking into the changes required so you can assign this issue to me!
@pichlermarc
Copy link
Member

@timfish It's yours, thanks for looking into it 🙂

@pichlermarc
Copy link
Member

cc @JamieDanielson @pkanal (component owners)

@timfish

This comment was marked as outdated.

Sign in to view
@timfish timfish linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timfish timfish

Labels
feature-request pkg:instrumentation-express
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(instrumentation-express): Add support for Express v5 timfish/opentelemetry-js-contrib
2 participants
@timfish @pichlermarc