[Koa] koa plugin instrumentation doesnt generalize http routes

[AndrewGrachov]

• This only affects the JavaScript OpenTelemetry library
• This may affect other libraries, but I would like to get opinions here first

having http and koa intrumentation enabled

Expectation:
I see traces grouped by koa routes

Reality:

I see every incoming http request as separate operation which is not really useable. Do I do something wrong, or this is an issue?

[morigs]

Related to open-telemetry/opentelemetry-js#897
See spec

[jmealo]

I just reviewed the tests for the koa instrumentation and it looks like this already works properly for traces (even using nested routers): https://github.com/open-telemetry/opentelemetry-js-contrib/blob/master/plugins/node/opentelemetry-koa-instrumentation/test/koa-router.test.ts#L155

It looks like this is a matter of setting the name on the request span from the koa instrumentation as it has become more generic in the http plugin.

[AndrewGrachov]

@Madamas, pls confirm that you dont have this issue anymore, and we can close that :)

[Madamas]

yep, works like a charm in latest version, thanks for heads-up