Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable dns as a default plugin #205

Closed
1 of 2 tasks
naseemkullah opened this issue Sep 15, 2020 · 2 comments
Closed
1 of 2 tasks

re-enable dns as a default plugin #205

naseemkullah opened this issue Sep 15, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@naseemkullah
Copy link
Member

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first

As per gitter chat with @dyladan and @obecny :

The dns is currently disabled as we need to watch for:

any case where creating a span may result in a DNS request, the DNS request may itself trigger a new trace, which may result in a new DNS request, and so on.

However,

with latest changes ver. 0.11 it should automatically surpress tracing for all exporters

Yes that is an important point. The context property to suppress tracing is set in the span processor

if that is happening for dns you might want to add surpressing manually then so the plugin will not cause creating a new span

and at least for collector I have checked that and it was working fine

I also heard from someone that it worked for zipkin that they weren't seeing recursive http calls

@vmarchaud
Copy link
Member

We could totally enable it by default indeed.

@vmarchaud
Copy link
Member

I think we can close this @naseemkullah ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants