Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-instrumentation-aws-lambda] Context handling does not follow Semantic Conventions for Instrumenting AWS Lambda #1726

Open
1 of 2 tasks
ithompson-gp opened this issue Oct 11, 2023 · 2 comments

Comments

@ithompson-gp
Copy link

ithompson-gp commented Oct 11, 2023

Issue

According to official trace semantic conventions for Instrumenting AWS Lambda, given an AWS Lambda - generated - sampled trace context (_X_AMZN_TRACE_ID), this context must be supplied - via instrumentation - as a Span Link when initialising a Span encapsulating the - wrapped - function handler being invoked.

This expected functionality is explained in detail in the same semantic conventions doc in the AWS X-Ray Environment Span Link section.

Which plugin?

Where in code?

Actions?

Given the inconsistencies between Lambda trace conventions and code being shipped, is there a timeline for solving these inconsistencies?

  • This only affects the JavaScript OpenTelemetry library
  • This may affect other libraries, but I would like to get opinions here first
@srprash
Copy link

srprash commented Oct 17, 2023

Hi @ithompson-gp
There's already an open PR regarding this FaaS specification: #1411

There is ongoing discussions on accepting the PR since it is a breaking change for Lambda customers.

@ithompson-gp
Copy link
Author

ithompson-gp commented Oct 24, 2023

@srprash Has there been any move to merge this (#1411)?
As an end-user, we would like conventions to be respected, and move forward with developing Span Link as a means to represent causal relationships in an async EDA.
This is a true blocker to any FaaS adoption of OpenTelemetry (lack of Span Link in end systems and the development on the OTEL side to integrate with Messaging SIG)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants