-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(instrumentation-amqplib): move @types/amqplib
into dev deps
#1320
Conversation
This is problematic because the types from amqplib are used in public types. Therefore this would result in build problems for users of e.g. Therefore the exposed API of this instrumentation needs to be changed to no longer use these types. |
@AbhiPrasad Thanks for opening this PR. As mentioned in the comments, the suggested fix is currently problematic. Are you still interested in finalizing it? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1320 +/- ##
==========================================
- Coverage 96.08% 95.05% -1.03%
==========================================
Files 14 18 +4
Lines 893 1275 +382
Branches 191 280 +89
==========================================
+ Hits 858 1212 +354
- Misses 35 63 +28
|
Hey folks - sorry for the delay, was on vacation the past month.
Yes I am! Will update the PR as soon as I can. |
Created a |
751fced
to
3fcf648
Compare
3fcf648
to
d7b573a
Compare
@blumamir Thank you for the review. I made the changes as requested. Ended up removing internal types as it wasn't needed, everything needs to be exposed. Added notes around where I vendored the types from, as well as the version + git sha and included links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM, added 2 minor comments and then we can merge :)
Thanks for all the help @blumamir - appreciate it! |
Hey? Is there a timeline to get this merged and released? Anything I can do to help here? |
Sorry about the delay. updated the branch and will merge when CI finish. Thanks again for the contribution |
Which problem is this PR solving?
Don't include
@types/amqplib
in the final bundle with theamqplib
instrumentation. This can cause issues if you are using an old typescript version (as you can type checks the deps of@types/amqplib
).Short description of the changes
Move
@types/amqplib
intodevDependencies
fromdependencies