fix(instrumentation-amqplib): move @types/amqplib into dev deps

[AbhiPrasad]

Which problem is this PR solving?

Don't include @types/amqplib in the final bundle with the amqplib instrumentation. This can cause issues if you are using an old typescript version (as you can type checks the deps of @types/amqplib).

Short description of the changes

Move @types/amqplib into devDependencies from dependencies

[Flarna]

This is problematic because the types from amqplib are used in public types.

Therefore this would result in build problems for users of e.g. @opentelemetry/auto-instrumentations-node if they have these types not installed.

Therefore the exposed API of this instrumentation needs to be changed to no longer use these types.

[osherv]

So that means, you need to create a new internal-types.ts that includes the types, as implemented here.
also, in some places, you probably can change the signature of the function arg types to be any.
You can see an example here.

[blumamir]

@AbhiPrasad Thanks for opening this PR. As mentioned in the comments, the suggested fix is currently problematic. Are you still interested in finalizing it?
@osherv described a possible fix that will not expose the package types in public APIs, and you can also further read here

[codecov]

Codecov Report

Merging #1320 (8353d80) into main (ad92673) will decrease coverage by 1.03%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
- Coverage   96.08%   95.05%   -1.03%     
==========================================
  Files          14       18       +4     
  Lines         893     1275     +382     
  Branches      191      280      +89     
==========================================
+ Hits          858     1212     +354     
- Misses         35       63      +28     

Impacted Files	Coverage Δ
plugins/node/instrumentation-amqplib/src/types.ts	100.00% <ø> (ø)
...lugins/node/instrumentation-amqplib/src/amqplib.ts	90.40% <100.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts	98.21% <0.00%> (ø)
plugins/node/instrumentation-amqplib/src/utils.ts	95.38% <0.00%> (ø)

[AbhiPrasad]

Hey folks - sorry for the delay, was on vacation the past month.

As mentioned in the comments, the suggested fix is currently problematic. Are you still interested in finalizing it?

Yes I am! Will update the PR as soon as I can.

[AbhiPrasad]

Created a internal-types.ts and vendored in the appropriate types.

[AbhiPrasad]

@blumamir Thank you for the review. I made the changes as requested. Ended up removing internal types as it wasn't needed, everything needs to be exposed. Added notes around where I vendored the types from, as well as the version + git sha and included links.

[blumamir]

Thanks!
LGTM, added 2 minor comments and then we can merge :)

[AbhiPrasad]

Thanks for all the help @blumamir - appreciate it!

[AbhiPrasad]

Hey? Is there a timeline to get this merged and released? Anything I can do to help here?

[blumamir]

Sorry about the delay. updated the branch and will merge when CI finish.

Thanks again for the contribution