Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda - http #132

Closed
obecny opened this issue Jul 9, 2020 · 6 comments
Closed

AWS Lambda - http #132

obecny opened this issue Jul 9, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@obecny
Copy link
Member

obecny commented Jul 9, 2020

Is your plugin request related to a problem? Please describe

Currently on lambda function all the incoming requests are not "catched" / "handled" by http module. This causes that the http plugin is not creating any new span and when you try to get currentSpan in handler function it returns undefined.
We should investigate this issue further and see if we can come out with some plugin solution that could mimic the behaviour of http plugin instrumentation only for incoming requests.
When lambda functions is doing any http request those requests are being instrumented correctly, but there is no information from the incoming / outside request that "hits" lambda

Is it applicable for Node or Browser or both

Node

Do you expect this plugin to be commonly used

could be

What version of plugin are you interested in using

latest

Additional context

This can improve the tracing information. In a contrast on GCP the incoming request is using the http module so the context propagation is kept.

@dyladan dyladan transferred this issue from open-telemetry/opentelemetry-js Jul 9, 2020
@dyladan
Copy link
Member

dyladan commented Jul 9, 2020

Transferred this to contrib. If you think it should be in core let me know and we can maybe move it back.

@dyladan
Copy link
Member

dyladan commented Jul 9, 2020

I have been working on this already and should have a PR incoming for the first part of this sometime early next week.

@obecny
Copy link
Member Author

obecny commented Jul 9, 2020

With regards to keeping this in contrib. Hard to say before seeing the PR, but if the plugin depends on our http plugin or its existence makes sense only if you use http plugin then I would keep it core. WDYT ? But I would like to hear feedback from @mayurkale22 as well

@dyladan
Copy link
Member

dyladan commented Jul 9, 2020

It will not depend on the HTTP plugin and will handle more invocation types than just http.

@obecny
Copy link
Member Author

obecny commented Jul 9, 2020

It will not depend on the HTTP plugin and will handle more invocation types than just http.

then I would leave it in contrib :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants