-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update experimental deps to ^0.34.0
, core deps to ^1.8.0
, api to ^1.3.0
#1278
Conversation
I think the build failure here is in packages/opentelemetry-host-metrics:
Maybe pull in the changes from #1281? Edit: There is more, e.g.
|
excludes `@opentelemetry/instrumentation-aws-lambda`, which is not yet compatible with `@opentelemetry/instrumentation@^0.34.0`
90d483e
to
1da1280
Compare
@Flarna Where did you see the error in This should be ready for re-run. |
Please avoid force pushing. It makes it harder to follow history and also I believe if you don't force push it will allow the workflows to keep running without re-approval |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
- Coverage 96.08% 92.49% -3.59%
==========================================
Files 14 118 +104
Lines 893 6158 +5265
Branches 191 1222 +1031
==========================================
+ Hits 858 5696 +4838
- Misses 35 462 +427
|
@mhassan1 the title of the PR is "update experimental deps to ^0.34.0." Your PR also updates core dependencies and peer dependencies on You can use #1143 as reference. |
I put that explanation in the PR description. We need to upgrade the |
^0.34.0
, core deps to ^1.8.0
, api to ^1.3.0
Thanks for the explanation. Now the codebase mixes core package versions. some are at |
I created open-telemetry/opentelemetry-js#3408 as this mix is not only here. |
Any details? Maybe best to create a new issue and tag the AWS lambda instrumentation owners about this. |
@blumamir I was trying to keep this pull request focused on getting experimental packages to
|
I see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for doing this, adding my moral support 🙂
The coverage report doesn't really make sense. This may be the result of uploading reports from multiple test branches (web and node). In any case this PR didn't change coverage so i think it's ok. |
Yay! Is there a time estimate for when this'll get released? 🙂 |
Which problem is this PR solving?
This PR updates experimental dependencies to
^0.34.0
across all packages (except@opentelemetry/instrumentation-aws-lambda
, which is not yet compatible with@opentelemetry/instrumentation@^0.34.0
, see #1285). It also upgrades@opentelemetry/api
peer dependencies to^1.3.0
in order to satisfy^0.34.0
.Short description of the changes
This PR updates
package.json
files across the repository for the following dependencies (to^0.34.0
):@opentelemetry/instrumentation
@opentelemetry/instrumentation-fetch
@opentelemetry/instrumentation-xml-http-request
@opentelemetry/instrumentation-http
@opentelemetry/instrumentation-grpc
@opentelemetry/sdk-node
@opentelemetry/exporter-trace-otlp-http
It also updates those
package.json
files with upgraded@opentelemetry/api
peer dependencies (to^1.3.0
) to satisfy the experimental dependency upgrades (#3340) , which led to upgrades of the following dependencies (to^1.8.0
, see #3340):@opentelemetry/core
@opentelemetry/context-async-hooks
@opentelemetry/context-zone-peer-dep
@opentelemetry/resources
@opentelemetry/sdk-trace-base
@opentelemetry/sdk-trace-node
@opentelemetry/sdk-trace-web