Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppressing Zipkin exporter's instrumentations #5967

Closed
LikeTheSalad opened this issue Nov 8, 2023 · 6 comments
Closed

Suppressing Zipkin exporter's instrumentations #5967

LikeTheSalad opened this issue Nov 8, 2023 · 6 comments
Assignees
@chungngoops
Labels
Feature Request Suggest an idea for this project help wanted

Comments

@LikeTheSalad
Copy link
Contributor

LikeTheSalad commented Nov 8, 2023 •
edited
Loading

Add instrumentation suppressing context key to the exporter. Similar to what was done for OkHttp-related exporters here.
@LikeTheSalad LikeTheSalad added the Feature Request Suggest an idea for this project label Nov 8, 2023
@LikeTheSalad LikeTheSalad changed the title Identifying Suppressing Zipkin exporter's instrumentations Nov 8, 2023
@LikeTheSalad LikeTheSalad mentioned this issue Nov 8, 2023
Merged
@chungngoops
Copy link
Contributor

I'm working on this issue.

@breedx-splk
Copy link
Contributor

Hi @chungngoops . Any updates?

@chungngoops
Copy link
Contributor

@breedx-splk : sorry I didn't have time to continue the work, but back on it now.

@SylvainJuge
Copy link
Contributor

The way to suppress Zipkin exporter instrumentation might change a bit if #6546 is merged.

@chungngoops
Copy link
Contributor

I created a draft PR #6552, I am struggling with creating test for the new changes, could anyone help me with this.

@chungngoops chungngoops mentioned this issue Jul 4, 2024
Merged
@breedx-splk
Copy link
Contributor

I think this is done. @LikeTheSalad reopen if not the case. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chungngoops chungngoops

Labels
Feature Request Suggest an idea for this project help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SylvainJuge @chungngoops @LikeTheSalad @breedx-splk