-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a service.instance.id
if it is not present?
#5103
Comments
I'm in favor of adding this to the default resource, and I think this specific sentence from the semantic conventions makes it reasonable to do:
@srikanthccv do you know if any other language SDKs include it by default? |
I know erlang does it by default, and Python and JS have planned to include it by default, but it hasn't been implemented yet. |
FYI I opened spec issue #3136 to request clarity on whether SDKs should generate a value for |
Resolved in #6226. |
Spec says https://github.com/open-telemetry/opentelemetry-specification/tree/v1.6.1/specification/resource/semantic_conventions#service
The built-in default Resource doesn't appear to do this. While it is not mandatory by specification, it is important when scaling a service horizontally.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/data-model.md#single-writer
https://github.com/open-telemetry/opentelemetry-specification/blob/7e9ba1683995c34846b942fbc23c3290610e9347/specification/compatibility/prometheus_and_openmetrics.md#resource-attributes
The text was updated successfully, but these errors were encountered: