Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit exemplar functionality until stable #4272

Closed
jack-berg opened this issue Mar 17, 2022 · 0 comments · Fixed by #4276
Closed

Limit exemplar functionality until stable #4272

jack-berg opened this issue Mar 17, 2022 · 0 comments · Fixed by #4276
Labels
Feature Request Suggest an idea for this project metrics

Comments

@jack-berg
Copy link
Member

The metric sdk spec is looking to move to mixed status, with exemplars marked as "Feature-freeze". Without being marked as stable, I think we should take some precautions in the public API we expose related to exemplars.

Exemplars show up in just one place in our API: we allow ExemplarFilter to be registered with SdkMeterProviderBuilder#setExemplarFilter(ExemplarFilter). As discussed in #2421, this configuration is actually explicitly stated anywhere.

The other exemplar component is ExemplarReservoir. The spec says that reservoirs can be optionally specified via views, but we don't actually allow this. This means that users are stuck with the default reservoir strategy, and in particular, the default reservoir size which is based on the the number of available CPUs.

Some thoughts:

  • Are we sure SdkMeterProvider is the right place for ExemplarFilter to be configured? I think probably yes.
  • Do we want to allow custom implementations of ExemplarFilter, or only allow the three defaults (none, all, with_sampled_trace)? If not, we can adjust it to being an empty interface with internal implementations. I think its probably wise to disallow custom implementations for now.
  • Should we keep ExemplarReservoir a public interface? I think no, since there is no ability to configure ExemplarReservoir anywhere in the API.
@jack-berg jack-berg added Feature Request Suggest an idea for this project metrics labels Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project metrics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant