-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch Jaeger remote sampler to "grpc" lite mechanism #4014
Comments
@anuraaga the remote sampler needs to get the response from the grpc service. So far the grpc lite mechanism is not parsing the response e.g. - Line 40 in a1a45d2
Any preferences how it should be done? I have started by defining |
@pavolloffay For the remote sampler, I don't think we need an additional abstraction, we should be able to use that type of class for the gRPC stub, and actually implement the RESPONSE_MARSHALER instead of returning a singleton. |
The issue is that we need logic from Line 14 in a1a45d2
{OkHttp,Default}GrpcExporterBuilder to make it all work.
an abstraction that would handle generic response type would be helpful. |
I see - in that case the interface you mentioned does seem like a reasonable direction. I don't expect to need it outside the Jaeger sampler artifact though so if there is a solution that keeps things simpler without abstracting more than needed, we don't need to consider anything very general. FWIW, I think we could consider making |
Is your feature request related to a problem? Please describe.
This is required for open-telemetry/opentelemetry-java-instrumentation#4898 (comment)
I am starting to work on this
The text was updated successfully, but these errors were encountered: