Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Histogram indexing improvements #3842

Closed
jamesmoessis opened this issue Nov 9, 2021 · 1 comment
Closed

Exponential Histogram indexing improvements #3842

jamesmoessis opened this issue Nov 9, 2021 · 1 comment
Labels
Feature Request Suggest an idea for this project metrics

Comments

@jamesmoessis
Copy link
Contributor

The spec defines multiple ways of indexing for exponential histogram buckets for different scales. Currently the indexing strategy is a simple log based one that works for all scales (it has some error in edge cases, and is slightly slower). See #3724 (comment) for some discussion regarding this.

What needs to be done

  • Different implementations of BucketMapper should be made and these can be switched out when the scale changes in DoubleExponentialHistogramBuckets. Reference implementations in Golang can be found here: OTEP 149: Base-2 exponential histogram mapping reference implementation oteps#179
  • Testing, for indexing implementations
  • Testing the limits of the exponential histogram by adding to existing tests. For example, record Double.MAX_VALUE and Double.MIN_VALUE in the same histogram, and ensure accuracy.
@jack-berg
Copy link
Member

This was completed in #4700.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project metrics
Projects
None yet
Development

No branches or pull requests

3 participants