-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support process.runtime.* resource attributes #1908
Comments
A provider-based implementation could look like this: public class ProcessRuntimeResourceProvider extends ResourceProvider {
@Override
protected Attributes getAttributes() {
return Attributes.of(
PROCESS_RUNTIME_NAME,
System.getProperty("java.runtime.name"),
PROCESS_RUNTIME_VERSION,
System.getProperty("java.runtime.version"),
PROCESS_RUNTIME_DESCRIPTION,
System.getProperty("java.vm.vendor") + ' ' + System.getProperty("java.vm.version"));
}
} |
My opinion: we should report them by default. |
@anuraaga From some looking around, it seems that |
Here's my gist for reference https://gist.github.com/anuraaga/c79219a7e4401515c3de998f9d077be0 I think one thing that lead me to the current properties is I think this allowed OpenJ9 to model well. It's still OpenJDK, but with different VM. So keeping |
Admittedly, I thought client VM had already been deleted by now... But I'd also assume any use case for telemetry would force server mode on anyways, which I guess requires a flag on 32-bit? |
Indeed, if I use the |
For J9, what would be the problem with using ( |
@anuraaga I created open-telemetry/opentelemetry-specification#1242 to add the |
There should be support for the process.runtime.* resource attributes, which should contain information about the monitored JVM.
Spec: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/resource/semantic_conventions/process.md#java-runtimes
Note that I made a spec PR to split process.runtime from process, so that these resources can be reported independently: open-telemetry/opentelemetry-specification#1137
Since these values are trivial to gather (just
System.getProperty
), it might make sense to always report them out of the box along with the telemetry SDK.Or instead it may make sense to add them to a provider separate from the current process provider.
The text was updated successfully, but these errors were encountered: