Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporter has TLS enabling controlled by a flag called insecure #1673

Closed
anuraaga opened this issue Sep 22, 2020 · 0 comments · Fixed by #1725
Closed

Exporter has TLS enabling controlled by a flag called insecure #1673

anuraaga opened this issue Sep 22, 2020 · 0 comments · Fixed by #1725
Assignees
@jkwatson
Labels
Bug Something isn't working good first issue help wanted priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release

Comments

@anuraaga
Copy link
Contributor

I've stared a while to make sure I'm not missing something but I'm pretty sure we implement the insecure flag opposite of intention.

https://github.com/open-telemetry/opentelemetry-java/blob/master/exporters/otlp/src/main/java/io/opentelemetry/exporters/otlp/OtlpGrpcSpanExporter.java#L197

Also FYI possibly changing the default - open-telemetry/opentelemetry-specification#975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkwatson jkwatson

Labels
Bug Something isn't working good first issue help wanted priority:p2 Medium priority issues and bugs. release:required-for-ga Required for 1.0 GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix the backwards TLS/insecure config options jkwatson/opentelemetry-java
2 participants
@anuraaga @jkwatson