-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intermittent exception when installing HikariCP instrumentation #9744
Comments
Can you reproduce this at will? I guess we could disable this validation, but the weird thing is that unlike what the exception claims |
@laurit Unfortunately we don't know how to reproduce the issue reliably. We are thinking about forking the projects and adding more logs specific to this issue whenever possible, so the next time it happens we have more information. Do you have any other suggestions on where we could start or what we should try debugging? And forgive me about the stack trace, the one I sent was indeed from an older version. Here's one from
Another curious thing that we noticed now is that we noticed now is that similar errors also occur when transforming other classes, for example:
and
This makes us think that the problem is not related to HikariCP per se, and the lack of metrics is just the sympton. But we are kind of lost in how to investigate further. |
How often do you see this? As this exception doesn't make sense I'd probably try with a different java version or disable jit compiler for |
This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed automatically if there is no response from the author within 7 additional days from this comment. |
Describe the bug
Sometimes, during the agent installation on application startup, it throws an exception when transforming the
com.zaxxer.hikari.pool.HikariPool
class. When this happensdb.client
metrics related to our HikariCP connection pools are not reported.Steps to reproduce
The exception is intermittent and seemingly random. With the same configuration, most of the times the agent is able to report everything just fine. But other times the exception occurs and the application replica doesn't report any
db.client
metrics. We noticed the problem when querying some db metrics and realizing some instances were not reporting anything, even when db connections were happening.To understand the problem better, we activated debug logs and ran a routine to recreate some of our pods from time to time. Then we noticed the correlation between the exception and the metrics not being reported.
Expected behavior
The
db.client
metrics for HikariCP should always be reported when there are db connections.Actual behavior
Sometimes, in a seemingly random fashion, the
db.client
metrics for HikariCP are not being reported even when the application has active db connections.Javaagent or library instrumentation version
v1.30.0
Environment
JDK: Temurin 11.0.15
OS: Alpine 3.16.1
HikariCP 5.0.1
Additional context
Java Agent properties:
The text was updated successfully, but these errors were encountered: