Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there benefit in having a shared AttributeKey cache in an .internal. class in instrumentation-api? #5003

Closed
trask opened this issue Jan 3, 2022 · 1 comment
Closed

Is there benefit in having a shared AttributeKey cache in an .internal. class in instrumentation-api? #5003

trask opened this issue Jan 3, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Jan 3, 2022

Tracking issue for #4968 (comment)
@trask trask added the enhancement New feature or request label Jan 3, 2022
@trask trask mentioned this issue Jan 3, 2022
Merged
@trask
Copy link
Member Author

trask commented Aug 26, 2023

Closing, this can be added later. Sort of want to be careful about leaning on internal APIs from instrumentations where it's not too important since I suspect our instrumentations are (or will be) used as references of how to build your own library instrumentation.

@trask trask closed this as completed Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trask