Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a ClassAndMethod class to Instrumentation API? #4592

Closed
trask opened this issue Nov 4, 2021 · 1 comment · Fixed by #4619
Closed

Add a ClassAndMethod class to Instrumentation API? #4592

trask opened this issue Nov 4, 2021 · 1 comment · Fixed by #4619
Labels
enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Nov 4, 2021

Several instrumentations have copies of this kind of class (with different names), it may make sense to have this in Instrumentation API (one less helper class that needs to be injected).
@trask trask added the enhancement New feature or request label Nov 4, 2021
@trask
Copy link
Member Author

trask commented Nov 4, 2021

This would also be a good place to document why not to use @Advice.Origin Method method

@laurit laurit mentioned this issue Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a ClassAndMethod class to Instrumentation API laurit/opentelemetry-java-instrumentation
1 participant
@trask