Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotlessApply conflicts with checkstyleMain inside switch #3706

Closed
anosek-an opened this issue Jul 28, 2021 · 0 comments · Fixed by #6218 or #6219
Closed

spotlessApply conflicts with checkstyleMain inside switch #3706

anosek-an opened this issue Jul 28, 2021 · 0 comments · Fixed by #6218 or #6219
Labels
bug Something isn't working

Comments

@anosek-an
Copy link
Contributor

Describe the bug
When a comment is placed inside switch right above case: line, ./gradlew spotlessApply adds indents that cause ./gradlew checkstyleMain to fail.
If those indents are removed, checkstyleMain passes but spotlessCheck fails.

  • only ./gradlew spotlessCheck passing (notice the indent before // TODO):
    indents

  • only ./gradlew checkstyleMain passing:
    no-indents

(example based on DbSpanDecorator.java)

Steps to reproduce

  • add comment line above case: in any switch statement (for example DbSpanDecorator.java)
  • run ./gradlew spotlessApply - adds indents
  • run ./gradlew checkstyleMain- fails because of the idents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update spotless
Remove checkstyle CommentsIndentation
1 participant
@anosek-an