Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly build #3400

Closed
github-actions bot opened this issue Jun 24, 2021 · 4 comments · Fixed by #3407
Closed

Nightly build #3400

github-actions bot opened this issue Jun 24, 2021 · 4 comments · Fixed by #3407
Assignees
Labels
area:build Issues about build infra, both local and central bug Something isn't working

Comments

@github-actions
Copy link
Contributor

Nightly build #10 failed. Please take a look and fix it ASAP.
@github-actions github-actions bot added area:build Issues about build infra, both local and central bug Something isn't working priority:p1 labels Jun 24, 2021
@iNikem
Copy link
Contributor

iNikem commented Jun 24, 2021

Seems like Armeria tests failed. @anuraaga can you take a look please?

@iNikem iNikem assigned anuraaga and unassigned iNikem Jun 24, 2021
@anuraaga
Copy link
Contributor

FYI @trustin @ikhoon @minwoox I won't be able to look until tomorrow but you may want to check this out. Our tests which target the latest version of a library started failing with 1.9.0 which usually indicates an unintended bug or breaking change.

@trustin
Copy link

trustin commented Jun 24, 2021

I'm not sure if it's related, but we changed how we initialize the client request context in 1.9.0 - line/armeria#3636

@minwoox
Copy link

minwoox commented Jun 24, 2021

I think I have to dig more but this change make it work:

  void sendRequestWithCallback(HttpRequest request, String method, URI uri, Map<String, String> headers, RequestResult requestResult) {
    Context ctx = Context.current();
    client.execute(request).aggregate().whenComplete {response, throwable ->
      ctx.makeCurrent().withCloseable {
        requestResult.complete({ response.status().code() }, throwable)
      }
    }
  }

@Override
void sendRequestWithCallback(HttpRequest request, String method, URI uri, Map<String, String> headers, RequestResult requestResult) {
client.execute(request).aggregate().whenComplete {response, throwable ->
requestResult.complete({ response.status().code() }, throwable)
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:build Issues about build infra, both local and central bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants