-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly build #3400
Labels
Comments
github-actions
bot
added
area:build
Issues about build infra, both local and central
bug
Something isn't working
priority:p1
labels
Jun 24, 2021
Seems like Armeria tests failed. @anuraaga can you take a look please? |
I'm not sure if it's related, but we changed how we initialize the client request context in 1.9.0 - line/armeria#3636 |
I think I have to dig more but this change make it work: void sendRequestWithCallback(HttpRequest request, String method, URI uri, Map<String, String> headers, RequestResult requestResult) {
Context ctx = Context.current();
client.execute(request).aggregate().whenComplete {response, throwable ->
ctx.makeCurrent().withCloseable {
requestResult.complete({ response.status().code() }, throwable)
}
}
} Lines 47 to 52 in f7a24b0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
The text was updated successfully, but these errors were encountered: