Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry API instrumentation (bridge) tests are only run against latest OTel API #3044

Closed
trask opened this issue May 19, 2021 · 5 comments · Fixed by #3555
Closed

OpenTelemetry API instrumentation (bridge) tests are only run against latest OTel API #3044

trask opened this issue May 19, 2021 · 5 comments · Fixed by #3555
Labels
bug Something isn't working

Comments

@trask
Copy link
Member

trask commented May 19, 2021

And no muzzle either.

We want to run muzzle against 1.0.0+, and we want to run tests at least against 1.0.0 and latest.

@trask trask added the bug Something isn't working label May 19, 2021
@mateuszrzeszutek
Copy link
Member

For muzzle to work we'd have to have multiple versions of application.io... shaded libs - the easiest way would probably be to publish opentelemetry-api-shaded-for-instrumenting

@trask
Copy link
Member Author

trask commented Jul 14, 2021

Let's keep this open to track publishing of the old versions and running the tests against 1.0.0 + latestDep

@trask trask reopened this Jul 14, 2021
@anuraaga
Copy link
Contributor

Is everyone comfortable with just changing the dependency version in the build.gradle.kts for the opentelemetry-api-shaded-for-instrumenting project instead of checking out old tags?

This actually made my brain realize - should we move this project to the opentelemetry-java repo for internal consumption? This repo's versions don't necessarily sync with that one at the patch level

@trask
Copy link
Member Author

trask commented Jul 15, 2021

Is everyone comfortable with just changing the dependency version in the build.gradle.kts for the opentelemetry-api-shaded-for-instrumenting project instead of checking out old tags?

👍

This actually made my brain realize - should we move this project to the opentelemetry-java repo for internal consumption? This repo's versions don't necessarily sync with that one at the patch level

oh, great thought, this totally makes sense

@trask
Copy link
Member Author

trask commented Dec 22, 2024

Closing, the situation is much better now, can revisit later if anyone has renewed interest.

@trask trask closed this as completed Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants