Refactor propagators #467
Merged
Refactor propagators #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
requested review from
iredelmeier,
jmacd,
lizthegrey,
paivagustavo,
rghetia and
tedsuo
as code owners
|
Fixes #457 too. |
jmacd
approved these changes
Feb 5, 2020
jmacd
reviewed
Feb 5, 2020
|
|
||
| // ExtractHTTP applies props.HTTPExtractors() to the passed context | ||
| // and the supplier and returns the combined result context. | ||
| func ExtractHTTP(ctx context.Context, props Propagators, supplier HTTPSupplier) context.Context { |
There was a problem hiding this comment.
There is a WIP on this topic that suggests the ExtractHTTP and InjectHTTP static methods here should be exposed composite extractor or injector, i.e., suggests that instead Propagators should implement HTTPExtractor and HTTPInjector interfaces itself.
There was a problem hiding this comment.
Please replace these static methods with Propagator methods.
There was a problem hiding this comment.
As discussed in the SIG, this will take a bit more work and it's OK to merge what we have here and do the rest in a future PR.
krnowak
force-pushed
the
krnowak/refactor-propagators
branch
2 times, most recently
from
c09ae13 to
db28c16
Compare
They are in process of being dropped from the specification and we haven't be using them anywhere in the project. Can reintroduce them later.
The supplier is used only in HTTP propagators currently. It's not clear if it will be useful for binary propagators if they get to be specified at some point.
The biggest change here is that HTTP extractors return a new context with whatever information the propagator is able to retrieve from the supplier. Such interface does not hardcode any extractor's functionality (like it was before by explicitly returning a span context and correlation context) and makes it easy to chain multiple propagators. Injection part hasn't changed.
This interface (and its default implementation) is likely going to be the propagation API used the most. Single injectors, extractors or propagators are likely going to be used just as parameters to the Option functions that configure the Propagators implementation.
It's rather pointless - just create an empty Propagators instance.
krnowak
force-pushed
the
krnowak/refactor-propagators
branch
from
db28c16 to
82d2a28
Compare
rghetia
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #457.