Move dependencies of tools package to a tools directory #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoden9014
requested review from
iredelmeier,
jmacd,
krnowak,
lizthegrey,
paivagustavo,
rghetia and
tedsuo
as code owners
theoden9014
changed the title
theoden9014
changed the title
rghetia
reviewed
Feb 4, 2020
Makefile
Outdated
| @@ -52,7 +56,7 @@ check-clean-work-tree: | |||
| .PHONY: build | |||
| build: | |||
| # TODO: Fix this on windows. | |||
| set -e; for dir in $(ALL_GO_MOD_DIRS); do \ | |||
| set -e; for dir in $(filter-out $(TOOLS_MOD_DIR), $(ALL_GO_MOD_DIRS)); do \ | |||
There was a problem hiding this comment.
only 'go mod tidy' is run for TOOLS_MOD_DIR. May be it is better to exclude TOOLS_MOD_DIR from ALL_GO_MOD_DIRS and explicitly run 'go mod tidy' on ALL + TOOLS.
There was a problem hiding this comment.
This is a good idea. The comment about ALL_GO_MOD_DIRS could be updated at the same time.
jmacd
approved these changes
Feb 4, 2020
krnowak
suggested changes
Feb 4, 2020
Makefile
Outdated
| @@ -1,10 +1,11 @@ | |||
| EXAMPLES := $(shell ./get_main_pkgs.sh ./example) | |||
| TOOLS_MOD_DIR := ./tools | |||
|
|
|||
| # All source code and documents. Used in spell check. | |||
| ALL_DOCS := $(shell find . -name '*.md' -type f | sort) | |||
| # All directories with go.mod files. Used in go mod tidy. | |||
There was a problem hiding this comment.
While following what @rghetia wrote in the review, could you update this comment? Maybe something like:
# All directories with go.mod files related to opentelemetry library. Used for building, testing and linting.
Makefile
Outdated
| @@ -52,7 +56,7 @@ check-clean-work-tree: | |||
| .PHONY: build | |||
| build: | |||
| # TODO: Fix this on windows. | |||
| set -e; for dir in $(ALL_GO_MOD_DIRS); do \ | |||
| set -e; for dir in $(filter-out $(TOOLS_MOD_DIR), $(ALL_GO_MOD_DIRS)); do \ | |||
There was a problem hiding this comment.
This is a good idea. The comment about ALL_GO_MOD_DIRS could be updated at the same time.
then run 'go mod tidy' on ALL_GO_MOD_DIRS and TOOLS_MOD_DIR.
rghetia
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, OpenTelemetry will be widely used in services. Therefore, remove any dependent packages that are not used in this implementation.