Some makefile fixes #442
Merged
Some makefile fixes #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated files may require some formatting that happens during linting. Also missing generated files may result in linter failures. Building can shake out any syntax/semantic errors and report them in a much nicer way than the linter does. Which is exactly the reason the build was running before linters before the Makefile simplification.
Lint target does not use the stringer utility - it is being used by go generate.
krnowak
requested review from
iredelmeier,
jmacd,
lizthegrey,
paivagustavo,
rghetia and
tedsuo
as code owners
paivagustavo
approved these changes
Jan 24, 2020
lizthegrey
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a dependency issue (generate target should depend on stringer, not lint target) and reorders the targets within precommit (so we generate files and build the code before doing linting, so we can get much nicer errors about syntax errors from the compiler)