Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PeriodicReader timeout for ForceFlush #4377

Merged
merged 2 commits into from
Jul 29, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jul 27, 2023

Prioritize the user passed context deadline if it has one.

From #3666 (comment)

Prioritize the user passed context deadline if it has one.
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #4377 (26c9441) into main (859a870) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4377     +/-   ##
=======================================
- Coverage   83.4%   83.4%   -0.1%     
=======================================
  Files        184     184             
  Lines      14371   14380      +9     
=======================================
+ Hits       11988   11995      +7     
- Misses      2155    2157      +2     
  Partials     228     228             
Files Changed Coverage Δ
sdk/metric/periodic_reader.go 84.8% <100.0%> (+0.6%) ⬆️

... and 1 file with indirect coverage changes

@MrAlias MrAlias marked this pull request as ready for review July 27, 2023 21:27
@MrAlias MrAlias merged commit 9418aca into open-telemetry:main Jul 29, 2023
@MrAlias MrAlias deleted the periodic-timeout branch July 29, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants