Format log message before logging with logr #4143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-telemetry#4141 The logr calling convention does not support fmt semantics for message formatting. Format the message before it is sent to logr for logging.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4143 +/- ##
=======================================
- Coverage 83.5% 83.5% -0.1%
=======================================
Files 181 181
Lines 14162 14162
=======================================
- Hits 11832 11830 -2
- Misses 2103 2105 +2
Partials 227 227
|
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Aneurysm9
approved these changes
May 27, 2023
pellared
reviewed
May 27, 2023
hanyuancheung
approved these changes
May 29, 2023
MadVikingGod
approved these changes
Jun 23, 2023
Co-authored-by: Robert Pająk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4141
The logr calling convention does not support fmt semantics for message formatting. Format the message before it is sent to logr for logging.