From b553b971ed33dbfddc7b42dd418009094816abeb Mon Sep 17 00:00:00 2001 From: Bogdan Drutu Date: Tue, 14 Dec 2021 10:38:06 -0800 Subject: [PATCH] Remove Min/Max unused interfaces from the moved code Signed-off-by: Bogdan Drutu --- sdk/export/metric/aggregation/aggregation.go | 15 +++++++++++---- sdk/metric/export/aggregation/aggregation.go | 12 ------------ 2 files changed, 11 insertions(+), 16 deletions(-) diff --git a/sdk/export/metric/aggregation/aggregation.go b/sdk/export/metric/aggregation/aggregation.go index 75617a237f7..09b20306051 100644 --- a/sdk/export/metric/aggregation/aggregation.go +++ b/sdk/export/metric/aggregation/aggregation.go @@ -15,6 +15,7 @@ package aggregation // import "go.opentelemetry.io/otel/sdk/export/metric/aggregation" import ( + "go.opentelemetry.io/otel/metric/number" "go.opentelemetry.io/otel/sdk/metric/export/aggregation" ) @@ -27,11 +28,17 @@ type Sum = aggregation.Sum // Deprecated: use module "go.opentelemetry.io/otel/sdk/metric/export/aggregation" type Count = aggregation.Count -// Deprecated: use module "go.opentelemetry.io/otel/sdk/metric/export/aggregation" -type Min = aggregation.Min +// Deprecated: Will be removed soon. +type Min interface { + Aggregation + Min() (number.Number, error) +} -// Deprecated: use module "go.opentelemetry.io/otel/sdk/metric/export/aggregation" -type Max = aggregation.Max +// Deprecated: Will be removed soon. +type Max interface { + Aggregation + Max() (number.Number, error) +} // Deprecated: use module "go.opentelemetry.io/otel/sdk/metric/export/aggregation" type LastValue = aggregation.LastValue diff --git a/sdk/metric/export/aggregation/aggregation.go b/sdk/metric/export/aggregation/aggregation.go index 4d5254ed71b..44c8c3320e2 100644 --- a/sdk/metric/export/aggregation/aggregation.go +++ b/sdk/metric/export/aggregation/aggregation.go @@ -46,18 +46,6 @@ type ( Count() (uint64, error) } - // Min returns the minimum value over the set of values that were aggregated. - Min interface { - Aggregation - Min() (number.Number, error) - } - - // Max returns the maximum value over the set of values that were aggregated. - Max interface { - Aggregation - Max() (number.Number, error) - } - // LastValue returns the latest value that was aggregated. LastValue interface { Aggregation