Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing shutdown of the batch processor in otel example #1186

Merged
merged 2 commits into from
Sep 20, 2020

Conversation

huikang
Copy link
Member

@huikang huikang commented Sep 18, 2020

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1186 into master will decrease coverage by 0.8%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1186     +/-   ##
========================================
- Coverage    77.9%   77.0%   -0.9%     
========================================
  Files         135     135             
  Lines        7192    5858   -1334     
========================================
- Hits         5603    4512   -1091     
+ Misses       1346    1104    -242     
+ Partials      243     242      -1     
Impacted Files Coverage Δ
sdk/trace/simple_span_processor.go 66.6% <0.0%> (-13.4%) ⬇️
sdk/trace/trace_go11.go 50.0% <0.0%> (-10.0%) ⬇️
sdk/resource/resource.go 57.5% <0.0%> (-8.6%) ⬇️
api/trace/api.go 57.1% <0.0%> (-8.4%) ⬇️
api/metric/numberkind_string.go 16.6% <0.0%> (-8.4%) ⬇️
api/metric/must.go 41.3% <0.0%> (-8.2%) ⬇️
internal/testing/alignment.go 37.5% <0.0%> (-8.0%) ⬇️
sdk/metric/aggregator/sum/sum.go 68.0% <0.0%> (-7.8%) ⬇️
api/metric/kind_string.go 10.0% <0.0%> (-6.7%) ⬇️
api/global/handler.go 73.3% <0.0%> (-6.7%) ⬇️
... and 125 more

@huikang huikang force-pushed the fix-shutdown-batchprocessor branch from bf38984 to 80fee59 Compare September 18, 2020 19:37
@huikang huikang force-pushed the fix-shutdown-batchprocessor branch from 80fee59 to 7cddf14 Compare September 18, 2020 23:14
@Aneurysm9 Aneurysm9 merged commit 930b4d0 into open-telemetry:master Sep 20, 2020
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants