Convert XConfigure into constructor for metrics #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow up of #1155.
rakyll
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
|
Adding a note to the changelog... |
jmacd
approved these changes
Sep 14, 2020
Aneurysm9
approved these changes
Sep 14, 2020
MrAlias
approved these changes
Sep 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #1175 +/- ##
======================================
Coverage 77.9% 77.9%
======================================
Files 135 135
Lines 7192 7192
======================================
+ Hits 5603 5604 +1
+ Misses 1346 1344 -2
- Partials 243 244 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up of #1155.