Add missing argument names to the Span interface #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though arbitrary-looking, new developers need to rely on docs to figure out the arguments. Self document them by naming.
rakyll
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1135 +/- ##
======================================
Coverage 77.2% 77.2%
======================================
Files 133 133
Lines 7101 7101
======================================
+ Hits 5488 5489 +1
+ Misses 1366 1364 -2
- Partials 247 248 +1
|
XSAM
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
It looks like tons of interface need update. Maybe we should update our Style Guide and unify all interfaces.
MrAlias
approved these changes
Sep 8, 2020
Created #1138 to track this. |
evantorrie
pushed a commit
to evantorrie/opentelemetry-go
that referenced
this pull request
Sep 10, 2020
Even though arbitrary-looking, new developers need to rely on docs to figure out the arguments. Self document them by naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though arbitrary-looking, new developers need to rely on docs
to figure out the arguments. Self document them by naming.