-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to check for presence of CHANGELOG changes on PRs #1067
Conversation
It looks like there may not be a way to mark the missing changelog as a warning rather than a failure. Thoughts on whether that's ok? |
I think for 99% of PRs this will be fine. The times it will not will be for I guess we could fix up the dependant stuff to add to the CHANGELOG and maybe also update this to see if the change was purely administrative (i.e. CODEOWNER was changed)? That or require CHANGELOG entries for the administrative stuff as well. |
I'd be happy to do this (make dependencies auto-fix include adding to the changelog). |
If it can add a |
I tend to agree that less clutter re: dependabot version upgrades would be a better choice - especially as the project matures. I created #1113 to track adding a |
@Aneurysm9 Could you create a "Skip Changelog" label with appropriate capitalization, etc? I can then take on implementing #1113. |
Label created. |
Fixes #932.