Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge both AddLink tests into one with subtests #5114

Closed
dmathieu opened this issue Mar 27, 2024 · 0 comments · Fixed by #5115
Closed

Merge both AddLink tests into one with subtests #5114

dmathieu opened this issue Mar 27, 2024 · 0 comments · Fixed by #5115
Milestone
untracked

Comments

@dmathieu
Copy link
Member

dmathieu commented Mar 27, 2024 •
edited by pellared
Loading

Both this test and the one above are very similar. How about refactoring them into a single one with options, and use subtests?
https://go.dev/blog/subtests

Originally posted by @dmathieu in #5032 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Merge Span.AddLink tests perhapsmaple/opentelemetry-go
2 participants
@dmathieu @XSAM