-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: Implement Stringer for Value and KeyValue #4952
Comments
I would like to have consensus if we want to have it in initial stable release. @MrAlias, do I remember correctly that you suggested removing this issue from the Logs RC project as it is NOT required by the OTel spec (it is only a convenience feature)? If so I am even leaning to closing this issue. |
I'm not opposed to adding this. There are two issues though:
|
Cannot the user create its own encoding (and even decoding) API that takes
I think it would be a user error. We could add a doc comment like (inspired by https://pkg.go.dev/time#Time.String):
|
The failure messages from assertions like this one (I changed the test to fail) convinced me to implement
Stringer
.Reference: #4809 (comment)
Originally posted by @pellared in #4949 (comment)
The text was updated successfully, but these errors were encountered: