Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of "/" in Metrics Instrument Names #4500

Closed
aabmass opened this issue Sep 12, 2023 · 0 comments · Fixed by #4501
Closed

Allow use of "/" in Metrics Instrument Names #4500

aabmass opened this issue Sep 12, 2023 · 0 comments · Fixed by #4501
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@aabmass
Copy link
Member

aabmass commented Sep 12, 2023

And update the validation

for _, c := range name[1:] {
if !isAlphanumeric(c) && c != '_' && c != '.' && c != '-' {
return fmt.Errorf("%w: %s: must only contain [A-Za-z0-9_.-]", ErrInstrumentName, name)
}
}

Then update spec compliance matrix https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants