Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle partial success responses from OTLP export services #3102

Closed
jmacd opened this issue Aug 19, 2022 · 0 comments · Fixed by #3106
Closed

Handle partial success responses from OTLP export services #3102

jmacd opened this issue Aug 19, 2022 · 0 comments · Fixed by #3106
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jmacd
Copy link
Contributor

jmacd commented Aug 19, 2022

Problem Statement

Following the specification change to add partial success responses, each OTel SDK is encouraged to handle the resulting error message string in an appropriate way, considering existing norms. This requires OTLP v0.19.

Proposed Solution

For each of the Export*ServiceRequest methods used by OTLP Trace and Metrics exporters, construct an error and call otel.Handle() with the error message string and the number of spans/points(/logs) dropped. Future OTel specifications may call for optional treatment of the number of dropped items, but presently that is just additional information to include in the handled error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants