Occasional error in unittest TestExporterShutdown/testClientStopHonorsTimeout

[Petrie]

Description

This is an error in unittest TestExporterShutdown/testClientStopHonorsTimeout

A few days ago, I open a pr #2987 , try fix golangci-lint not working correctly. But the pr checks occur a error in unittest TestExporterShutdown/testClientStopHonorsTimeout for exporter grpc client Stop() function :exporters/otlp/otlptrace/otlptracegrpc/client.go#L130

I figure out in Stop(ctx context.Context) the select for <-ctx.Done() and acquired may reach at the same time. In select if acquired be exec first, The Stop(ctx context.Context) function may return nil . when Stop(ctx context.Context) function return nil, unittest TestExporterShutdown/testClientStopHonorsTimeout and TestExporterShutdown/testClientStopHonorsTimeout will failure.

Environment

• OS: [Mac OS X]
• Architecture: [ i386]
• Go Version: [go version go1.17.11 darwin/amd64]
• opentelemetry-go version: [main]

Steps To Reproduce

cd exporters/otlp/otlptrace/otlptracegrpc/
while true ; do go clean -testcache | go list \
| xargs go test -v -timeout 60s -race -run \
  TestExporterShutdown/testClientStopHonorsTimeout; sleep 0.5;  done;

Wait for 2~3 minutes, the error while occur.

 

Expected behavior

The all unittest pass

[pellared]

I think it was fixed or at least I have not seen it for a very long time.