You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Create instrumentation.Scope that is the same shape as instrumentation.Library, and make Library an alias of Scope. This should be a non-breaking change, but should be checked.
Deprecate Instrumentation.Library, and move all sdk uses to Scope.
For each area in the SDK, trace metrics exporter etc, move as many references from Library to Scope. Examples would be internal struct names
For traces the biggest impediment is Span.InstrumentationLibrary(), we would need to add an extra Interface that could be checked and used1.
For Metrics there are a number of Interfaces that might need similar treatment
Alternatives
Change documentation to explain that Instrumentation Library should be treated as the Scope referenced in the specification.
Problem Statement
There has been a move in the specification to change the name of Instrumentation Libary to Instrumentation Scope. Our implementation should move away from using Library to Scope.
Proposed Solution
Take this in steps:
instrumentation.Scope
that is the same shape asinstrumentation.Library
, and make Library an alias of Scope. This should be a non-breaking change, but should be checked.Instrumentation.Library
, and move all sdk uses to Scope.Span.InstrumentationLibrary()
, we would need to add an extra Interface that could be checked and used1.Alternatives
Change documentation to explain that Instrumentation Library should be treated as the Scope referenced in the specification.
Prior Art
Footnotes
See the
io.Seeker
discussion in Module Compatibility - Working with interfaces ↩The text was updated successfully, but these errors were encountered: