Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong docs and defaults for OTEL_EXPORTER_JAEGER_AGENT_PORT #2130

Closed
pellared opened this issue Jul 26, 2021 · 0 comments · Fixed by #2131
Closed

Wrong docs and defaults for OTEL_EXPORTER_JAEGER_AGENT_PORT #2130

pellared opened this issue Jul 26, 2021 · 0 comments · Fixed by #2131
Assignees
@pellared
Labels
bug Something isn't working pkg:exporter:jaeger Related to the Jaeger exporter package
Milestone
untracked

Comments

@pellared
Copy link
Member

pellared commented Jul 26, 2021 •
edited
Loading

  1. There is a bug in README. Jeager agent is using jaeger.thrift over compact (not binary). See:

    opentelemetry-go/exporters/jaeger/agent.go

    Line 79 in 03902d9

    protocolFactory := thrift.NewTCompactProtocolFactoryConf(&thrift.TConfiguration{})
  2. The default port should be 6831 (not 6832) and it should be documented in README. See: https://www.jaegertracing.io/docs/1.22/getting-started/

Reference: open-telemetry/opentelemetry-specification#1812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
bug Something isn't working pkg:exporter:jaeger Related to the Jaeger exporter package
Projects
Go: Triage
Archived in project
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Fix Jaeger exporter agent port default value and docs pellared/opentelemetry-go
1 participant
@pellared