-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TraceState/Baggage fields currently should only accept string-string pairs #1539
Comments
Hello I would like to take on this issue |
@MrAlias I don't see a linked PR, so I'm going to assume you're fine with someone taking this off your hands! |
Notes from SIG meeting (2021-04-01):
|
Talking with Bogdan it was made clear we want the If we include a type it could lead to user expectation that we will correctly deserialize the type of their choosing. Meaning, for example, they create some enum type with a base type of an This may also be the same for baggage, but with the recent unification of attributes in metrics, there may be a situation where we want baggage to be transformed into attributes. Meaning that types may need to be communicated in the baggage. We are still exploring if this is a potential for the future and will plan based on findings. |
Regarding the baggage rework, it was pointed out today in the SIG meeting that if we restructure the Baggage to handle metadata and revert to just using strings we can always add on another layer that looks for type information (if it becomes available) and abstract that back to our KeyValue type. |
Currently they use the
label.KeyValue
. This is out of compliance with the spec.The text was updated successfully, but these errors were encountered: