Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many "trace" packages #1014

Closed
bogdandrutu opened this issue Jul 31, 2020 · 5 comments
Closed

Too many "trace" packages #1014

bogdandrutu opened this issue Jul 31, 2020 · 5 comments
Assignees
Labels
area:trace Part of OpenTelemetry tracing pkg:API Related to an API package pkg:SDK Related to an SDK package
Milestone

Comments

@bogdandrutu
Copy link
Member

import "go.opentelemetry.io/otel/api/trace"
import "go.opentelemetry.io/otel/sdk/trace"
import "go.opentelemetry.io/otel/sdk/export/trace"

It is very hard to work with all of these. Would suggest maybe use different names, maybe consider:
sdktrace for "go.opentelemetry.io/otel/sdk/sdktrace"
exptrace for "go.opentelemetry.io/otel/sdk/export/exptrace"

@jmacd
Copy link
Contributor

jmacd commented Aug 6, 2020

We discussed this in the SIG, and think that probably users should rename these imports as needed. Only SDK maintainers and exporter maintainers will have this trouble. Also note, e.g., in the metrics code we remap go.opentelemetry.io/otel/sdk/export/metric as

import export "go.opentelemetry.io/otel/sdk/export/metric"

@bogdandrutu
Copy link
Member Author

That is not true, I have this problem in my main file because I need to configure SDK/API and exporter.

@bogdandrutu
Copy link
Member Author

Also in tests because I need to use the test exporter

@MrAlias MrAlias added this to the RC1 milestone Sep 25, 2020
@MrAlias MrAlias added area:trace Part of OpenTelemetry tracing pkg:API Related to an API package pkg:SDK Related to an SDK package priority:p1 labels Sep 25, 2020
@MrAlias
Copy link
Contributor

MrAlias commented Sep 25, 2020

This is partially related to #964. I think we can try to do the same in the SDK and SDK exporter package.

@MrAlias
Copy link
Contributor

MrAlias commented Feb 18, 2021

Closing as there is not a desire to resolve across the SDK or API packages. The export package will likely be addressed in #1380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing pkg:API Related to an API package pkg:SDK Related to an SDK package
Projects
None yet
Development

No branches or pull requests

3 participants