Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor api/oterror #1011

Closed
MrAlias opened this issue Jul 31, 2020 · 0 comments · Fixed by #1026
Closed

Refactor api/oterror #1011

MrAlias opened this issue Jul 31, 2020 · 0 comments · Fixed by #1026
Assignees
@MrAlias
Labels
pkg:API Related to an API package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Jul 31, 2020

Based on recent feedback:

The name of this package breaks the style all the other packages are following. Why is this package is called oterror while other are not otmetric or ottrace?

This package can likely just be dissolved. The Handler interface can be moved to the global package and the only error (oterror.ErrSDKReturnedNilImpl) can be moved to the go.opentelemetry.io/otel top-level package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
pkg:API Related to an API package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the oterror package MrAlias/opentelemetry-go
1 participant
@MrAlias