Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument SetAttributes from default OTel default global impl #539

Closed
MrAlias opened this issue Dec 7, 2023 · 5 comments
Closed

Instrument SetAttributes from default OTel default global impl #539

MrAlias opened this issue Dec 7, 2023 · 5 comments

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Dec 7, 2023

Originally posted by @MrAlias in #523 (comment)
@MrAlias MrAlias mentioned this issue Dec 7, 2023
Merged
@asecondo
Copy link
Contributor

👋 i'll grab this one

@asecondo
Copy link
Contributor

actually, question for @RonFed - what's the intention behind this instrumentation? there's no SetError equivalent in the Span interface to map back to in the Go code and it looks like it only exists in the non recording span struct. is this instrumentation required?

@RonFed
Copy link
Contributor

RonFed commented Jan 14, 2024

actually, question for @RonFed - what's the intention behind this instrumentation? there's no SetError equivalent in the Span interface to map back to in the Go code and it looks like it only exists in the non recording span struct. is this instrumentation required?

Not sure.
@MrAlias can you elaborate on this one?

@MrAlias MrAlias changed the title Instrument SetError from default OTel default global impl Instrument SetAttributes from default OTel default global impl Jan 14, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 14, 2024

Right, I think that was a mistake. This should have been for SetAttributes. Updated.

@RonFed
Copy link
Contributor

RonFed commented Jan 15, 2024

Right, I think that was a mistake. This should have been for SetAttributes. Updated.

We have an instrumentation for that function, so maybe we can close this issue.

@MrAlias MrAlias closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Go Auto Instrumentation: Beta
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MrAlias @asecondo @RonFed